[Asterisk-code-review] tests/pjsip/config_options/remove_unavailable: Test new config option (testsuite[master])

Joe asteriskteam at digium.com
Wed Sep 22 20:37:47 CDT 2021


Attention is currently required from: Kevin Harwell.
Joe has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/16491 )

Change subject: tests/pjsip/config_options/remove_unavailable: Test new config option
......................................................................


Patch Set 3:

(2 comments)

File tests/channels/pjsip/registration/inbound/nominal/config_options/remove_unavailable/sipp/register-ipv4-remove-existing-enabled.xml:

https://gerrit.asterisk.org/c/testsuite/+/16491/comment/d4414714_3158ef0f 
PS3, Line 73: 			<ereg regexp="Contact: <sip:(charlie|carol)-2 at 127.0.0.3:5063>;expires=(60|5[5-9])" search_in="msg" check_it="true" assign_to="4"/>
> Should this contact not have been the one removed vs. the one at 127.0.0. […]
This one is reachable, only 5062 is unreachable. The pause to make unavailable is only after the first reg of 5062.  The purpose of writing the test this way is to ensure that the unavailable contact is removed instead of the one that expires soonest when it is available.


File tests/channels/pjsip/registration/inbound/nominal/config_options/remove_unavailable/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/16491/comment/1a18ffa3_cd79880a 
PS3, Line 56:                 - { 'key-args': {'scenario': 'register-ipv4-remove-existing-enabled.xml', '-i': '127.0.0.1', '-p': '5161', '-s': 'carol'} }
> Are you still getting the "Unable to bind main socket, errno = 98 (Address already in use). […]
I fixed this by changing the port to 5161 here and the error no longer occurs.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16491
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: I336bd2bac512396b33407882066a8ec66a914f5c
Gerrit-Change-Number: 16491
Gerrit-PatchSet: 3
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 01:37:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210922/1303cd78/attachment-0001.html>


More information about the asterisk-code-review mailing list