[Asterisk-code-review] apps/app_playback.c: Add 'mix' option to app_playback (asterisk[18])

[N A]

Attention is currently required from: George Joseph, Shloime Rosenblum.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16493 )

Change subject: apps/app_playback.c: Add 'mix' option to app_playback
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> An example would be if I want to play call logs I should be able to do `Playback(call-from&digit:&{c […]
Right, I'm saying that I think the way it is now, it's going to be a bit funny since you could do Playback(something,skipmix) or Playback(something,mixskip) or Playback(something,mix|noanswer) and those would all work. I guess that might be the best way to do it - you certainly can't use a comma as a delimeter right now. Just wanted to make sure that was considered. It would be more elegant if Playback had used letter options from the beginning, but it might be too late to change now I guess, even for new stuff. I just think it could be confusing, and a (recommended) usage example for how to specify multiple options would be good.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16493
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a
Gerrit-Change-Number: 16493
Gerrit-PatchSet: 2
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 01:00:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210922/0387f91a/attachment.html>