[Asterisk-code-review] apps/app_playback.c: Add 'mix' option to app_playback (asterisk[18])

[Shloime Rosenblum]

Attention is currently required from: N A, George Joseph.
Shloime Rosenblum has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16493 )

Change subject: apps/app_playback.c: Add 'mix' option to app_playback
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> Another thought, the "skip" and "noanswer" options are mutually exclusive, so previously Playback wa […]
An example would be if I want to play call logs I should be able to do `Playback(call-from&digit:&{callNumber}&on&datetime::${callTime},mix)` it should be able to play files from the sound directory and with say.conf on 1 line, if I use the say option it will ignore the files from the sound directory.

I built on top of what it does now and I did not try to change how the options work but it would definitely be helpful to be able to specify multiple options



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16493
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a
Gerrit-Change-Number: 16493
Gerrit-PatchSet: 2
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 00:47:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210922/98b11437/attachment.html>