[Asterisk-code-review] STIR/SHAKEN: Update config options and skip mismatch test. (testsuite[16])

[Benjamin Keith Ford]

Benjamin Keith Ford has uploaded this change for review. ( https://gerrit.asterisk.org/c/testsuite/+/16494 )


Change subject: STIR/SHAKEN: Update config options and skip mismatch test.
......................................................................

STIR/SHAKEN: Update config options and skip mismatch test.

The stir_shaken config option is being updated so that you can choose if
you want to do attestation, verification, or both. The tests need to be
updated for this as well.

For now, skip the mismatch test because we need a better solution than
bypassing the Date header to make things work as intended.

Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449
---
M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml
M tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf
6 files changed, 6 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/94/16494/1

diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf
index 675fafd..393a561 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf
@@ -15,7 +15,7 @@
 transport=transport-udp
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=attest
 
 [aor-bob]
 type=aor
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf
index 8b4dbb2..fcbfdcb 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf
@@ -13,4 +13,4 @@
 context=default
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=verify
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml b/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml
index ff6a57d..1d45eb7 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml
@@ -1,4 +1,5 @@
 testinfo:
+    skip: 'Skip until we have a better solution than bypassing Date header'
     summary:     'Tests STIR_SHAKEN_VERIFY_MISMATCH'
     description: |
         'Run one instance of Asterisk and set up an incoming call
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf
index 8b4dbb2..fcbfdcb 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf
@@ -13,4 +13,4 @@
 context=default
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=verify
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf
index 675fafd..393a561 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf
@@ -15,7 +15,7 @@
 transport=transport-udp
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=attest
 
 [aor-bob]
 type=aor
diff --git a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf
index 8b4dbb2..fcbfdcb 100644
--- a/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf
+++ b/tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf
@@ -13,4 +13,4 @@
 context=default
 allow=!all,ulaw
 callerid=1234567
-stir_shaken=yes
+stir_shaken=verify

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16494
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449
Gerrit-Change-Number: 16494
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210921/38a4146d/attachment.html>