[Asterisk-code-review] func_vmcount: Add support for multiple mailboxes (asterisk[master])

[N A]

Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16490 )

Change subject: func_vmcount: Add support for multiple mailboxes
......................................................................


Patch Set 5:

(4 comments)

Patchset:

PS3: 
> Make sure to compile with developer mode enabled: […]
Thanks, I think I have that on one of my test servers but not the other, so I'll be sure to do that.
In this case, I just edited online through the Gerrit web interface instead since it was just minor changes, and initially all was good but when I addressed your last comment I didn't move the declaration as was needed.


File funcs/func_vmcount.c:

https://gerrit.asterisk.org/c/asterisk/+/16490/comment/b95ef66a_49244aa1 
PS1, Line 91: 	while ((mailbox = strsep(&args.vmbox, "|"))) {
> Would & be a better delimiter or maybe comma? Is there precedent for using pipe?
I initially was going to use comma, but since there's already more than one arg (and these are comma-separated), that's more work to parse and more importantly will confuse users, so it has to be something that isn't a comma. I think & might be a better choice.


https://gerrit.asterisk.org/c/asterisk/+/16490/comment/505ba901_52c59a52 
PS1, Line 91: 	while ((mailbox = strsep(&args.vmbox, "|"))) {
> Also, whatever delimiter ends up being appropriate, make sure that you are tolerant of zero or more  […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16490/comment/4bcbde02_092f0dd5 
PS1, Line 92: 		total += ast_app_messagecount(mailbox, args.folder);
> The IMAP implementation of this in app_voicemail looks like it can return -1 in some cases (like bei […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16490
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9108528300795fd5b607efa9d4dd7b74be031813
Gerrit-Change-Number: 16490
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 20 Sep 2021 17:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210920/0bac7790/attachment.html>