[Asterisk-code-review] Resources/res_rtp_asterisk: Fix build failure due to missing symbols ... (asterisk[16])

Sean Bright asteriskteam at digium.com
Mon Sep 20 09:11:22 CDT 2021


Attention is currently required from: Guido Falsi.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16489 )

Change subject: Resources/res_rtp_asterisk: Fix build failure due to missing symbols when HAVE_PJPROJECT is false
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16489/comment/ea160091_e71dc96e 
PS1, Line 7: Resources/res_rtp_asterisk: Fix build failure due to missing symbols when HAVE_PJPROJECT is false
This should be 72 characters or less. Try this:

 res_rtp_asterisk.c: Fix build failure when not building with pjproject.

https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/c/asterisk/+/16489/comment/d4eed17c_32e912b2 
PS1, Line 10: Protect those code parts in
This sentence is cut off?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16489
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ib18d4392d51ac80ca5481dabf6e498a4e3e49e6f
Gerrit-Change-Number: 16489
Gerrit-PatchSet: 1
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Guido Falsi <madpilot at freebsd.org>
Gerrit-Comment-Date: Mon, 20 Sep 2021 14:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210920/e94fc04b/attachment.html>


More information about the asterisk-code-review mailing list