[Asterisk-code-review] func_vmcount: Add support for multiple mailboxes (asterisk[master])

[Sean Bright]

Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16490 )

Change subject: func_vmcount: Add support for multiple mailboxes
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File funcs/func_vmcount.c:

https://gerrit.asterisk.org/c/asterisk/+/16490/comment/4f33e7f1_11e59c3b 
PS1, Line 91: 	while ((mailbox = strsep(&args.vmbox, "|"))) {
Would & be a better delimiter or maybe comma? Is there precedent for using pipe?


https://gerrit.asterisk.org/c/asterisk/+/16490/comment/1e2713e3_4ba8c817 
PS1, Line 92: 		total += ast_app_messagecount(mailbox, args.folder);
The IMAP implementation of this in app_voicemail looks like it can return -1 in some cases (like being unable to find the specified mailbox) which is going to make the math wonky. I would check to make sure that the number returned is > 0 before adding it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16490
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9108528300795fd5b607efa9d4dd7b74be031813
Gerrit-Change-Number: 16490
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 20 Sep 2021 14:03:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210920/53fed310/attachment-0001.html>