[Asterisk-code-review] res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts (asterisk[16])

Joe asteriskteam at digium.com
Sun Sep 19 00:36:09 CDT 2021


Attention is currently required from: Sean Bright, George Joseph, Kevin Harwell.
Joe has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16160 )

Change subject: res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts
......................................................................


Patch Set 10:

(1 comment)

Patchset:

PS10: 
> Yes you can insert a "pause" between registrations. […]
I have a basic test version but I'm having a heck of a time trying to see if this works.

When trying to run all the scenarios, I'm getting this:
2021-09-19      01:21:45.856916 1632028905.856916: Unable to bind main socket, errno = 98 (Address already in use).
So I guess all the scenarios run synchronously.  With IPv4 I can work around this with 127.0.0.2, but what about IPv6?

Individually attempting to run a scenario I'm getting this:
[Sep 19 01:25:07] WARNING[25100]: asterisk.sipp:527 processEnded: Resolving remote host '127.0.0.1'...
[Sep 19 01:25:07] WARNING[25100]: asterisk.sipp:527 processEnded: Done.

I know Gerrit isn't really the place for WIP code but like I said I know almost nothing about SIPp or this testsuite framework.  Should put up the non-working code?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16160
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia2711b08f2b4d1177411b1be23e970d7fdff5784
Gerrit-Change-Number: 16160
Gerrit-PatchSet: 10
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Sun, 19 Sep 2021 05:36:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210919/b844a75f/attachment.html>


More information about the asterisk-code-review mailing list