[Asterisk-code-review] app_mf: Add full tech-agnostic MF support (asterisk[master])

[N A]

Attention is currently required from: George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16483 )

Change subject: app_mf: Add full tech-agnostic MF support
......................................................................


Patch Set 3:

(1 comment)

File apps/app_mf.c:

https://gerrit.asterisk.org/c/asterisk/+/16483/comment/5c18f7bb_171e9ae7 
PS3, Line 1: /*
> I don't think you can do it in gerrit but you can do it easily locally. […]
I was able to go through the procedure, but somehow the steps didn't seem to go through right and I feel certain I've screwed things up more. Eventually, I do get: fatal: It seems that there is already a rebase-merge directory, and
I wonder if you are in the middle of another rebase. and it complains of a merge conflict, but I don't see it in the file.

Now that the old app_mf is already merged into master, it seems like this isn't necessary. Is it fine if I abandon this review, push a new review for mf, wait until that is merged, then push the sf review? Probably any critique of app_mf will apply to app_sf as well, so that way I can easily make changes locally and push for review when finished.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16483
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I90cd3d401cf2ea81d3ea96fceba296be543aabb1
Gerrit-Change-Number: 16483
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Sat, 18 Sep 2021 12:47:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210918/59760882/attachment-0001.html>