[Asterisk-code-review] func_channel: Add CHANNEL_EXISTS function. (asterisk[master])

[N A]

Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16486 )

Change subject: func_channel: Add CHANNEL_EXISTS function.
......................................................................


Patch Set 4:

(7 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16486/comment/86a7403b_e8137608 
PS1, Line 7: func_channel: Add CHANNEL_EXISTS function
> There should be a period at the end of this line
Done


https://gerrit.asterisk.org/c/asterisk/+/16486/comment/e2891dcd_c862c2f0 
PS1, Line 9: Adds a function to check for the existence of a full channel name.
> It doesn't check for the existence of a full channel name, it checks for the existence of a channel.
Done


Patchset:

PS1: 
> This will also find a channel by unique ID if the match on name fails, so that would be something to […]
That's not what I intended, really, but I'm not opposed to that either and it doesn't seem like that would do any harm. Just trying to leverage the existing built-in functions and not reinvent the wheel there. I don't see a function for name only so I guess we'll have to do it this way.


File funcs/func_channel.c:

https://gerrit.asterisk.org/c/asterisk/+/16486/comment/ac78aba3_db65f747 
PS1, Line 23:  * \author Naveen Albert <asterisk at phreaknet.org>
> For next time - we don't typically do this unless we are adding a new file or substantially changing […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/16486/comment/ab1b3c9d_49b4facf 
PS1, Line 74: <para>Returns whether or not <replaceable>channel_name</replaceable> is a currently existing channel.
> Be specific about what is returned. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16486/comment/746a177c_d0153c94 
PS1, Line 75: <replaceable>channel_name</replaceable> must be a full channel name, not simply a tech/device.</para>
> Channel names are never simply tech/device so you can drop this sentence.
Done


https://gerrit.asterisk.org/c/asterisk/+/16486/comment/bb726a48_2648e0a6 
PS1, Line 729: 	snprintf(buf, maxlen, "%d", (ast_channel_get_by_name(data) ? 1 : 0));
> This leaks the channel
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16486
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib464e9eb6e13dc683a846286798fecff4fd943cb
Gerrit-Change-Number: 16486
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 15 Sep 2021 20:50:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210915/f104dc1e/attachment-0001.html>