[Asterisk-code-review] app_mf: Add full MF/SF support (asterisk[master])

[George Joseph]

Attention is currently required from: N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16481 )

Change subject: app_mf: Add full MF/SF support
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> I need to trunk to some systems which are SF-controlled only and do not accept MF. The other side of this is that the SF code that exists today in DAHDI is broken and basically useless. The SF requirements are the same as MF so this works perfectly and adds a tech agnostic way to do that.
> 
> I did some tested and it works perfectly, e.g. SendSF -> ReceiveSF.
> 
> There is also interest/need for this from other members of the community. The SF builds on the MF quite naturally so that's why it's there.

There's a big difference between MF and SF.  I can see MF as just a different tone matrix than DTMF.  For SF you have to accumulate and count 2600Hz pulses so while it may be convenient for you to lump them together, they're not architecturally related other than using the DSP.

> 
> What should I do with this review, exactly, delete/abandon it and then do what you'd mentioned?

1.  Abandon this review.
2.  In your local branch that has your other review, make your changes to support adding MF to Dial, leaving out all SF stuff, and save it as a new commit.  Don't amend the original commit.  Then do a 'git review' to upload.  This should complete your MF work.
3.  In that same branch, create a third commit with your SF changes AS A NEW APP (app_sf).  Don't lump it in with MF.  Do a 'git review' again.  I'm not sold on the idea of SF support yet but at least this will make it easier to deal with.

At the end, the SF review will have the second MF review as its parent, and the second MF review will have the first one as its parent.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16481
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I05ba61ce49092d3f131ade9dc4d97dcc9887fa1d
Gerrit-Change-Number: 16481
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 13 Sep 2021 16:07:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210913/329d65b3/attachment.html>