[Asterisk-code-review] app_queue: Fix hint updates for included contexts (asterisk[master])

N A asteriskteam at digium.com
Fri Sep 10 18:37:39 CDT 2021


Attention is currently required from: Sean Bright, George Joseph, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16411 )

Change subject: app_queue: Fix hint updates for included contexts
......................................................................


Patch Set 10:

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/16411/comment/f8e7c305_c8a0d0e1 
PS10, Line 2643: static int context_included(const char *parent, const char *child);
> I was wondering if that was the case. I wonder why that is. […]
Simply "No prototype for function..." error. I thought maybe it wouldn't need one if it was static but it seemed not, unless I did something else wrong.

The other option is make this a public ast_ function in pbx.h/c, if it's likely to be useful anywhere else.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16411
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8caf2f8da8157ef3d9ea71a8568c1eec95592b78
Gerrit-Change-Number: 16411
Gerrit-PatchSet: 10
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 10 Sep 2021 23:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210910/d35e62f3/attachment.html>


More information about the asterisk-code-review mailing list