[Asterisk-code-review] app_stack: Include current location if branch fails (asterisk[18])

N A asteriskteam at digium.com
Fri Sep 10 12:17:33 CDT 2021


N A has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/16475 )


Change subject: app_stack: Include current location if branch fails
......................................................................

app_stack: Include current location if branch fails

Previously, the error emitted when app_stack tries
to branch to a dialplan location that doesn't exist
has included only the information about the attempted
branch in the error log. This adds the current location
as well so users can see where the branch failed in
the logs.

ASTERISK-29626

Change-Id: Ia23502ab2ad21485a1ac74295063a8f25a6df5ce
---
M apps/app_stack.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/75/16475/1

diff --git a/apps/app_stack.c b/apps/app_stack.c
index 179694b..3c857a9 100644
--- a/apps/app_stack.c
+++ b/apps/app_stack.c
@@ -590,8 +590,8 @@
 	ast_channel_unlock(chan);
 
 	if (!ast_exists_extension(chan, dest_context, dest_exten, dest_priority, caller_id)) {
-		ast_log(LOG_ERROR, "Attempt to reach a non-existent destination for %s: (Context:%s, Extension:%s, Priority:%d)\n",
-			app_gosub, dest_context, dest_exten, dest_priority);
+		ast_log(LOG_ERROR, "%s attempted to reach non-existent destination '%s,%s,%d' from '%s,%s,%d'",
+			app_gosub, dest_context, dest_exten, dest_priority, orig_context, orig_exten, orig_priority);
 		goto error_exit;
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16475
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia23502ab2ad21485a1ac74295063a8f25a6df5ce
Gerrit-Change-Number: 16475
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210910/da57605a/attachment.html>


More information about the asterisk-code-review mailing list