[Asterisk-code-review] app_queue: Add LoginTime field for member in a queue. (asterisk[master])

George Joseph asteriskteam at digium.com
Fri Sep 10 10:10:17 CDT 2021


Attention is currently required from: Sean Bright, Kevin Harwell, Rodrigo Ramirez Norambuena.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16355 )

Change subject: app_queue: Add LoginTime field for member in a queue.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

Patchset:

PS4: 
> hrm yeah. Personally I think it'd be fine as people really shouldn't be relying on CLI output in that manner (screen scraping/parsing).
> 
> I _don't_ think we official support that kind of behavior at least, but let's get other opinions before moving forward.

I think we're fine to cherry-pick but go ahead and add a note to the CHANGES entry that the CLI changed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16355
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ied6c3a300f78d78eebedeb3e16a1520fc3fff190
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 4
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Comment-Date: Fri, 10 Sep 2021 15:10:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210910/c930ebdd/attachment.html>


More information about the asterisk-code-review mailing list