[Asterisk-code-review] func_env: Add DIRNAME and BASENAME functions (asterisk[master])

N A asteriskteam at digium.com
Fri Sep 3 12:34:33 CDT 2021


Attention is currently required from: Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16407 )

Change subject: func_env: Add DIRNAME and BASENAME functions
......................................................................


Patch Set 2:

(1 comment)

File funcs/func_env.c:

https://gerrit.asterisk.org/c/asterisk/+/16407/comment/72799a32_487137cb 
PS1, Line 1376: AST_MODULE_INFO_STANDARD(ASTERISK_GPL_KEY, "Environment/filesystem dialplan functions");
> You removed the line terminator from the last line.
I've done this before, and I remember intentionally adding a new line to avoid this happening again but I guess that didn't pan out. Anyways, fixed!



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16407
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id3aeb907f65c0ff96b6e57751ff0cb49d61db7f3
Gerrit-Change-Number: 16407
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 17:34:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210903/adb389b1/attachment.html>


More information about the asterisk-code-review mailing list