[Asterisk-code-review] resource_channels.c: Fix wrong external media parameter parse (asterisk[master])

[Kevin Harwell]

Attention is currently required from: Sungtae Kim.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16404 )

Change subject: resource_channels.c: Fix wrong external media parameter parse
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16404/comment/787609a7_0108e1a8 
PS2, Line 11: ASTERISK-29622
> Hm... that's strange. I checked this asterisk-18.3.0 and current master branch. […]
Yes I copied it just like you have it on the issue. Not sure what's going on, but I'll chalk it up to user error on my end :-). Especially since I missed my other question too.


File res/ari/resource_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/16404/comment/7fb7be80_c1250d07 
PS2, Line 2192: 	if (args->variables) {
              : 		struct ast_json *json_variables;
              : 
              : 		ast_ari_channels_external_media_parse_body(args->variables, args);
              : 		json_variables = ast_json_object_get(args->variables, "variables");
              : 		if (json_variables
              : 			&& json_to_ast_variables(response, json_variables, &variables)) {
              : 			return;
              : 		}
              : 	}
> Because make the ast_ari_channels_external_media_parse_body() function before than parameter validat […]
Okay yeah I see now, and makes sense. I totally missed the ast_ari_channels_external_media_parse_body call for some reason.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16404
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I49509c48a6cbc0fb4165bfa4f834b5e8b9ace20d
Gerrit-Change-Number: 16404
Gerrit-PatchSet: 2
Gerrit-Owner: Sungtae Kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sungtae Kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 02 Sep 2021 19:18:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sungtae Kim <pchero21 at gmail.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210902/ce369a42/attachment-0001.html>