[Asterisk-code-review] time: add support for time64 libc (asterisk[master])

[Sebastian Kemper]

Sebastian Kemper has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16621 )

Change subject: time: add support for time64 libc
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
Hi all,

In the meantime I received some feedback on the musl mailing list. Not related to asterisk, but related to time64. The feedback is here ([1]) and basically suggests to not hardcode platform details. Instead it was suggested to always use "lld" and cast all values to be formatted to "long long". This also resulted in a pull request to freeswitch project with proposed changes ([2]).

Not sure what your take is on this, but if you also thing this is a good idea then let me know and I'll change it here likewise.

[1] https://www.openwall.com/lists/musl/2021/10/27/3
[2] https://github.com/signalwire/freeswitch/pull/1409

Kind regards,
Seb



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16621
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic8d61b26033f5c486b917e738c9608b0923a844e
Gerrit-Change-Number: 16621
Gerrit-PatchSet: 3
Gerrit-Owner: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Sun, 31 Oct 2021 15:31:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211031/8c63058a/attachment.html>