[Asterisk-code-review] ast_coredumper: Refactor to better find things (asterisk[master])

George Joseph asteriskteam at digium.com
Thu Oct 28 13:50:43 CDT 2021


Hello Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/16657

to look at the new patch set (#3).

Change subject: ast_coredumper:  Refactor to better find things
......................................................................

ast_coredumper:  Refactor to better find things

The search for a running asterisk when --running is used
has been greatly simplified and in the event it doesn't
work, you can now specify a pid to use on the command
line with --pid.

The search for asterisk modules when --tarball-coredumps
is used has been enhanced to have a better chance of finding
them and in the event it doesn't work, you can now specify
--libdir on the command line to indicate the library directory
where they were installed.

The DATEFORMAT variable was renamed to DATEOPTS and is now
passed to the 'date' utility rather than running DATEFORMAT
as a command.

The coredump and output files are now renamed with DATEOPTS.
This can be disabled by specifying --no-rename.

Several confusing and conflicting options were removed:
--append-coredumps
--conffile
--no-default-search
--tarball-uniqueid

The script was re-structured to make it easier for follow.

Change-Id: I674be64bdde3ef310b6a551d4911c3b600ffee59
---
M configs/samples/ast_debug_tools.conf.sample
M contrib/scripts/ast_coredumper
A doc/CHANGES-staging/ast_coredumper.txt
3 files changed, 567 insertions(+), 488 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/57/16657/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16657
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I674be64bdde3ef310b6a551d4911c3b600ffee59
Gerrit-Change-Number: 16657
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211028/b789a2c5/attachment-0001.html>


More information about the asterisk-code-review mailing list