[Asterisk-code-review] app_voicemail: Fix phantom voicemail bug on rerecord (asterisk[master])

N A asteriskteam at digium.com
Mon Oct 25 17:10:43 CDT 2021


Attention is currently required from: N A.
Hello Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/16631

to look at the new patch set (#2).

Change subject: app_voicemail: Fix phantom voicemail bug on rerecord
......................................................................

app_voicemail: Fix phantom voicemail bug on rerecord

If users are able to press # for options while leaving
a message and then press 3 to rerecord the message, if
the caller hangs up during the rerecord prompt but before
Asterisk starts recording a message, then an "empty"
voicemail gets processed whereby an email gets sent out
notifying the user of a 0:00 duration message. The file
doesn't actually exist, so playback will fail since there
was no message to begin with.

This adds a check after the streaming of the rerecord
announcement to see if the caller has hung up. If so,
we bail out early so that we can clean up properly.

ASTERISK-29391 #close

Change-Id: Id965d72759a2fd3b39afb76fec08aaebebe75c31
---
M apps/app_voicemail.c
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/31/16631/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16631
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id965d72759a2fd3b39afb76fec08aaebebe75c31
Gerrit-Change-Number: 16631
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211025/7cf5004c/attachment.html>


More information about the asterisk-code-review mailing list