[Asterisk-code-review] strings/json: Add string delimter match, and object create with vars ... (asterisk[16])

[Kevin Harwell]

Attention is currently required from: George Joseph, Benjamin Keith Ford.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16642 )

Change subject: strings/json: Add string delimter match, and object create with vars methods
......................................................................


Patch Set 3:

(6 comments)

File include/asterisk/json.h:

https://gerrit.asterisk.org/c/asterisk/+/16642/comment/0252406e_b9d67516 
PS1, Line 544: \param excludes Variable names to exclude (optional)
> Comma separated?  Space separated?, etc?
Done


File main/json.c:

https://gerrit.asterisk.org/c/asterisk/+/16642/comment/e8cb45d3_89f33c4a 
PS1, Line 867: strstr(excludes, i->name)
> If you exclude ABC, than all variables that have ABC somewhere in the name will be excluded.   I.E. […]
Done


File main/strings.c:

https://gerrit.asterisk.org/c/asterisk/+/16642/comment/f318fc82_8baf6120 
PS2, Line 444: 
> This function doesn't handle "abc, def, ghi" (with the spaces after the commas. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16642/comment/c718c060_0666bcb2 
PS2, Line 451: 		haystack = end + 1;
> change this to  […]
Done


File tests/test_json.c:

https://gerrit.asterisk.org/c/asterisk/+/16642/comment/dcf5702b_44627158 
PS1, Line 1112: 	/* NULL case */
> You should probably also test that "ABC" doesn't match "MYABC2" in the excludes string.
Done


File tests/test_strings.c:

https://gerrit.asterisk.org/c/asterisk/+/16642/comment/b95ec8d4_ea998cdd 
PS2, Line 696: 
> I'd add tests with at least 3 items in the haystack so you can test front, middle and end. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16642
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5f34f18e102126aef3997f19a553a266d70d6226
Gerrit-Change-Number: 16642
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Benjamin Keith Ford <bford at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Mon, 25 Oct 2021 17:22:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211025/f59e43b9/attachment.html>