[Asterisk-code-review] app_assert: Add Assert application (asterisk[master])

N A asteriskteam at digium.com
Sun Oct 24 11:26:05 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16629 )

Change subject: app_assert: Add Assert application
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS1: 
> Okay, well people doing test cases and other testing in the dialplan would use it in a way similar t […]
Also, sample output in the logs:

pbxdev*CLI> channel originate Local/s at t application wait 10
[Oct 24 12:14:05] WARNING[144438][C-00000001]: app_assert.c:147 assert_exec: Assertion failed at t,s,4: $[${EPOCH}=5]
[Oct 24 12:14:05] WARNING[144438][C-00000001]: app_assert.c:147 assert_exec: Assertion failed at t,s,5: 0
[Oct 24 12:14:05] WARNING[144438][C-00000001]: app_assert.c:147 assert_exec: Assertion failed at t,s,6: $[${EPOCH}=35]

Looking at logs or in the CLI, it's very clear to see what assumptions were made that weren't true. Three lines of dialplan. You can't do this at all currently, and you can't get close without many more lines.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16629
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia089c2debf608f42f5f87e6c29d50e8ebcc093e5
Gerrit-Change-Number: 16629
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sun, 24 Oct 2021 16:26:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211024/78e13d82/attachment.html>


More information about the asterisk-code-review mailing list