[Asterisk-code-review] app_assert: Add Assert application (asterisk[master])

Joshua Colp asteriskteam at digium.com
Sun Oct 24 11:16:34 CDT 2021


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16629 )

Change subject: app_assert: Add Assert application
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> It's supposed to be analogous to the C function, to make doing this easy. […]
Most individuals writing dialplan or looking at it would not know what assert() means in C. I also don't see this being used in the testsuite, because we already use the ExecIf pattern so that we can know everything that failed - and not just fail at one point, as well as to raise specific information through AMI events.

Personally I'm against including this. I won't -1 at this point, others can provide their own input and thoughts.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16629
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia089c2debf608f42f5f87e6c29d50e8ebcc093e5
Gerrit-Change-Number: 16629
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sun, 24 Oct 2021 16:16:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211024/199e56b5/attachment.html>


More information about the asterisk-code-review mailing list