[Asterisk-code-review] res_speech: Add a type conversion, and new engine unregister methods (asterisk[16])

Sean Bright asteriskteam at digium.com
Thu Oct 21 15:29:10 CDT 2021


Attention is currently required from: Kevin Harwell.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16645 )

Change subject: res_speech: Add a type conversion, and new engine unregister methods
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File res/res_speech.c:

https://gerrit.asterisk.org/c/asterisk/+/16645/comment/44c441f6_5d987726 
PS1, Line 291: 		return "unknown";
Maybe an ast_assert(0) here instead?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16645
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I0f7de17cb411021c09fb03988bc2b904e1380192
Gerrit-Change-Number: 16645
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 21 Oct 2021 20:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211021/9ead2c52/attachment.html>


More information about the asterisk-code-review mailing list