[Asterisk-code-review] various: Fix GCC 11 compilation issues. (asterisk[master])
George Joseph
asteriskteam at digium.com
Thu Oct 21 10:49:04 CDT 2021
Attention is currently required from: Michael Bradeen, Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16571 )
Change subject: various: Fix GCC 11 compilation issues.
......................................................................
Patch Set 8: Code-Review+1
(4 comments)
Patchset:
PS8:
Go ahead and re-cherry-pick.
File addons/ooh323c/src/memheap.c:
https://gerrit.asterisk.org/c/asterisk/+/16571/comment/4916e5cf_7a051c8e
PS5, Line 1155: ast_mutex_unlock(&pMemHeap->pLock);
> This source file was always horribly formatted and you don't have to fix all the issues but Asterisk […]
Done
File tests/test_linkedlists.c:
https://gerrit.asterisk.org/c/asterisk/+/16571/comment/20aa3f1d_6ba62485
PS6, Line 190: if (AST_LIST_REMOVE(&test_list, &stackbogus, list)) {
> > This is an odd one indeed. […]
Done
File tests/test_linkedlists.c:
https://gerrit.asterisk.org/c/asterisk/+/16571/comment/3cb17817_f3d2ee58
PS7, Line 151: else {
: memset(bogus, 0, sizeof(*bogus));
: }
:
> Don't need the "else" block. […]
Done
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16571
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If4fe42222c8444dc16828a42731ee53b4ce5cbbe
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 21 Oct 2021 15:49:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211021/409e236d/attachment.html>
More information about the asterisk-code-review
mailing list