[Asterisk-code-review] STIR/SHAKEN: Update config options and skip some tests. (testsuite[master])

Benjamin Keith Ford asteriskteam at digium.com
Thu Oct 21 09:24:22 CDT 2021


Attention is currently required from: Benjamin Keith Ford.
Hello Joshua Colp, Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/testsuite/+/16524

to look at the new patch set (#2).

Change subject: STIR/SHAKEN: Update config options and skip some tests.
......................................................................

STIR/SHAKEN: Update config options and skip some tests.

The stir_shaken config option is being updated so that you can choose if
you want to do attestation, verification, or both. The tests need to be
updated for this as well.

For now, skip all the tests except stir_shaken_success. We are going to
need to switch to sipp for these tests since response codes are being
sent back now and we can no longer check the verification result to pass
the tests. Some additional work is going to needed for this since we
will have to have a way to pass in a dynamic Identity and Date header to
sipp.

Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449
---
M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast1/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_failed/configs/ast2/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_failed/test-config.yaml
M tests/channels/pjsip/stir_shaken/stir_shaken_mismatch/test-config.yaml
M tests/channels/pjsip/stir_shaken/stir_shaken_not_present/configs/ast2/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_not_present/test-config.yaml
M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast1/pjsip.conf
M tests/channels/pjsip/stir_shaken/stir_shaken_success/configs/ast2/pjsip.conf
8 files changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/24/16524/2
-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16524
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: I9b6186dc74dc1c34637a8ea9f4be4c8bf8f8f449
Gerrit-Change-Number: 16524
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211021/7757f944/attachment.html>


More information about the asterisk-code-review mailing list