[Asterisk-code-review] STIR/SHAKEN: Option split and response codes. (asterisk[16])

[Benjamin Keith Ford]

Attention is currently required from: Joshua Colp, George Joseph, Kevin Harwell.
Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16497 )

Change subject: STIR/SHAKEN: Option split and response codes.
......................................................................


Patch Set 6:

(5 comments)

File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/16497/comment/401773cb_515a877d 
PS3, Line 852: unsigned int
> I was wondering about this too, but could changing it to an enum potentially change the size of this […]
Ack


File include/asterisk/res_stir_shaken.h:

https://gerrit.asterisk.org/c/asterisk/+/16497/comment/44679e41_244a446b 
PS3, Line 25: /* Response codes from RFC8224 */
            : #define STIR_SHAKEN_RESPONSE_CODE_STALE_DATE 403
            : #define STIR_SHAKEN_RESPONSE_CODE_USE_SUPPORTED_PASSPORT_FORMAT 428
            : #define STIR_SHAKEN_RESPONSE_CODE_BAD_IDENTITY_INFO 436
            : #define STIR_SHAKEN_RESPONSE_CODE_UNSUPPORTED_CREDENTIAL 437
            : 
> I'd make this an enum with  STIR_SHAKEN_RESPONSE_CODE_PASSED = 200 and  STIR_SHAKEN_RESPONSE_CODE_SY […]
Ack


File res/res_pjsip/pjsip_configuration.c:

https://gerrit.asterisk.org/c/asterisk/+/16497/comment/370409dd_8666e445 
PS5, Line 733: 		ast_log(LOG_WARNING, "'%s' is not a valid value for option "
> This should be a hard fail. It should be up to the user to then fix their configuration.
Done


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/16497/comment/828309ad_40031653 
PS3, Line 4070: ast_sip_rdata_get_header_value
> Commented on this in other thread. Feel free to correct my thinking if it's wrong.
Done


File res/res_pjsip_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/16497/comment/5d011aa4_6cfad754 
PS3, Line 140: 	sscanf(remainder, "%79s", timezone);
> Yeah I believe checking the result is sufficient, and something you'd want to do either way. […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16497
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4ac1ecf652cd0e336006b0ca638dc826b5b1ebf7
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 6
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 21 Oct 2021 14:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211021/8f4b8c0b/attachment.html>