[Asterisk-code-review] STIR/SHAKEN: Option split and response codes. (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Wed Oct 20 11:06:36 CDT 2021


Attention is currently required from: Benjamin Keith Ford.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16497 )

Change subject: STIR/SHAKEN: Option split and response codes.
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

File res/res_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/16497/comment/a8ed4818_b1ac7eda 
PS4, Line 749: struct ast_stir_shaken_payload *ast_stir_shaken_verify(const char *header, const char *payload, const char *signature,
             : 	const char *algorithm, const char *public_cert_url)
             : {
> Not really a bug, but since this function and verify2 appear to be identical except for the added re […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16497
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4ac1ecf652cd0e336006b0ca638dc826b5b1ebf7
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 5
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Wed, 20 Oct 2021 16:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211020/1ffb6481/attachment-0001.html>


More information about the asterisk-code-review mailing list