[Asterisk-code-review] build: prevent binary downloads for non x86 architectures (asterisk[18])

[George Joseph]

George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/16612 )

Change subject: build: prevent binary downloads for non x86 architectures
......................................................................

build: prevent binary downloads for non x86 architectures

download_externals: Add check for i686 and i386 (in addition
to the current x86_64) and exit if not one of the three.

ASTERISK-26497

Change-Id: Ia4d429fcefa5b2f5b6e99159d4607de8e8325b2f
---
M build_tools/download_externals
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/build_tools/download_externals b/build_tools/download_externals
index f27271f..54a604e 100755
--- a/build_tools/download_externals
+++ b/build_tools/download_externals
@@ -73,8 +73,13 @@
 
 if [[ "${HOST_CPU}" = "x86_64" ]] ; then
 	host_bits=64
-else
+elif [[ "${HOST_CPU}" = "i386" ]] ; then
 	host_bits=32
+elif [[ "${HOST_CPU}" = "i686" ]] ; then
+	host_bits=32
+else
+	echo "${module_name}: External module downloading is not available for the ${HOST_CPU} platform.  Only x86 based platforms are currently supported.  Please disable this module in menuselect."
+	exit 1
 fi
 
 if [[ -z "${variant}" ]] ; then

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16612
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia4d429fcefa5b2f5b6e99159d4607de8e8325b2f
Gerrit-Change-Number: 16612
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211015/846c67a0/attachment-0001.html>