[Asterisk-code-review] various: Fix GCC 11 compilation issues. (asterisk[master])

[George Joseph]

Attention is currently required from: Michael Bradeen, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16571 )

Change subject: various: Fix GCC 11 compilation issues.
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16571/comment/7fc4f6c7_539cb15d 
PS5, Line 12: test_linkedlist: 'bogus' variable was manually allocated from a macro, and the
            : test fails if this happens but the compiler couldn't 'see' this and returns a
            : warning. 'stackbogus' variable used instead for the warned test instead.
            : chan_ooh323: Fixed various indentation issues that triggered misleading indentation
            : warnings.
            : 
Long lines.  Keep them under 72.
Also too many "instead"s. 😊


File addons/ooh323c/src/memheap.c:

https://gerrit.asterisk.org/c/asterisk/+/16571/comment/39761a23_8cd02e12 
PS5, Line 1155: 	      ast_mutex_unlock(&pMemHeap->pLock);
This source file was always horribly formatted and you don't have to fix all the issues but Asterisk coding guidelines require braces around all "if" constructs.
Since you have to update teh review anyways, change this to:
} else {
    ast_mutex...
}


File addons/ooh323c/src/ooh323.c:

https://gerrit.asterisk.org/c/asterisk/+/16571/comment/09645bb6_a9a6f34f 
PS5, Line 1069:       }
              : 	   if (call->h225version >= 4) {
              : 		   ret =ooSendTCSandMSD(call);
              : 	   }
              : 	   if (ret != OO_OK) {
              : 		   return ret;
              :       }
More mess (not your doing).  I think if you tried to fix the indentation here it'd look worse so you can leave this one alone.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16571
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If4fe42222c8444dc16828a42731ee53b4ce5cbbe
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 15 Oct 2021 12:23:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211015/f49be9a1/attachment-0001.html>