[Asterisk-code-review] build: prevent binary downloads for non x86 architectures (asterisk[16])

[George Joseph]

Attention is currently required from: Michael Bradeen, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16578 )

Change subject: build: prevent binary downloads for non x86 architectures
......................................................................


Patch Set 3:

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16578/comment/d48b0689_355a9baa 
PS1, Line 7: build: prevent binary downloads for non Intel architectures
> Also, AMD dang nabbit! :P non-x86
Done


File build_tools/download_externals:

https://gerrit.asterisk.org/c/asterisk/+/16578/comment/39584b9c_9e3aaee1 
PS1, Line 81: 	echo "${module_name}: External module downloading is not applicable for non-intel architectures.  Please disable in menuselect."
> What about AMD?!? […]
Done


File build_tools/download_externals:

https://gerrit.asterisk.org/c/asterisk/+/16578/comment/81e4fa6e_37ba95df 
PS2, Line 81:  platform you are on
> How about "...for the ${HOST_CPU} platform. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16578
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia4d429fcefa5b2f5b6e99159d4607de8e8325b2f
Gerrit-Change-Number: 16578
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 15 Oct 2021 12:08:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211015/e0e608c0/attachment-0001.html>