[Asterisk-code-review] build: prevent binary downloads for non Intel architectures (asterisk[16])

[Joshua Colp]

Attention is currently required from: Michael Bradeen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16578 )

Change subject: build: prevent binary downloads for non Intel architectures
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File build_tools/download_externals:

https://gerrit.asterisk.org/c/asterisk/+/16578/comment/bf9a7c89_bd9f09d6 
PS1, Line 81: 	echo "${module_name}: External module downloading is not applicable for non-intel architectures.  Please disable in menuselect."
What about AMD?!?

I think from a user perspective something like "External module downloading is not available for the platform you are on. Only x86 based platforms are currently supported. Please disable this module in menuselect." is probably better.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16578
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia4d429fcefa5b2f5b6e99159d4607de8e8325b2f
Gerrit-Change-Number: 16578
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Friendly Automation
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 12 Oct 2021 18:24:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211012/93d387c4/attachment.html>