[Asterisk-code-review] various: Fix GCC 11 compilation issues. (asterisk[master])

[Sean Bright]

Attention is currently required from: Michael Bradeen, Joshua Colp.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16571 )

Change subject: various: Fix GCC 11 compilation issues.
......................................................................


Patch Set 4: Code-Review+1

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16571/comment/dea86f9a_6ab87b18 
PS1, Line 7: test_voicemail_api.c: changing empty_msg_ids from 0 element array to empty char*
           : chan_skinny.c: changed calledParty size to AST_MAX_EXTENSION
           : menuselect Makefile: added -Wno-deprecated-declarations
> You should add a one-liner description, followed by a blank line, followed by the more detailed expl […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16571/comment/657f4246_2cff8aa0 
PS1, Line 13: SWP-11547
> No one outside of Sangoma knows what this is. […]
Done


File menuselect/Makefile:

https://gerrit.asterisk.org/c/asterisk/+/16571/comment/7b5ec06a_b9958a9a 
PS1, Line 25: CFLAGS+=-g -D_GNU_SOURCE -Wall -Wno-deprecated-declarations
> To the best of my knowledge this is for the GTK menuselect functionality, I think at the very least  […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16571/comment/7bf3bd52_567ac68f 
PS1, Line 25: CFLAGS+=-g -D_GNU_SOURCE -Wall -Wno-deprecated-declarations
> Can you please document what deprecated functions are in use that necessitates this change?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16571
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If4fe42222c8444dc16828a42731ee53b4ce5cbbe
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 12 Oct 2021 14:50:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211012/64bf0ef4/attachment.html>