[Asterisk-code-review] various: Fix GCC 11 compilation issues. (asterisk[master])

[Joshua Colp]

Attention is currently required from: Michael Bradeen, Sean Bright.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16571 )

Change subject: various: Fix GCC 11 compilation issues.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File menuselect/Makefile:

https://gerrit.asterisk.org/c/asterisk/+/16571/comment/6c47fbb9_6fd63671 
PS1, Line 25: CFLAGS+=-g -D_GNU_SOURCE -Wall -Wno-deprecated-declarations
> What error is this papering over? Would it be cleaner to stop using the deprecated functions?
To the best of my knowledge this is for the GTK menuselect functionality, I think at the very least we need a comment here specifying it - or to limit this to that functionality only. I'd go so far as to see about removing it in master.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16571
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If4fe42222c8444dc16828a42731ee53b4ce5cbbe
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 11 Oct 2021 15:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211011/4e2d4042/attachment.html>