[Asterisk-code-review] Makefile: Use basename in a POSIX-compliant way. (asterisk[master])

[Joshua Colp]

Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/16591 )

Change subject: Makefile: Use basename in a POSIX-compliant way.
......................................................................

Makefile: Use basename in a POSIX-compliant way.

If you aren't using GNU coreutils, chances are that your basename
doesn't know about the -s argument. Luckily for us, basename does what
we need it do even without the -s argument.

Change-Id: I8b81a429bb037b997ee6640ff8a2b5e860962bb7
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, approved; Approved for Submit
  George Joseph: Looks good to me, but someone else must approve



diff --git a/Makefile b/Makefile
index a2e52f1..63db501 100644
--- a/Makefile
+++ b/Makefile
@@ -493,7 +493,7 @@
 			MODULEINFO=$$($(AWK) -f build_tools/get_moduleinfo $$i) ; \
 			if [ -n "$$MODULEINFO" ] ; \
 			then \
-				echo "<module language=\"en_US\" name=\"`$(BASENAME) -s .c $$i`\">" >> $@ ; \
+				echo "<module language=\"en_US\" name=\"`$(BASENAME) $$i .c`\">" >> $@ ; \
 				echo "$$MODULEINFO" >> $@ ; \
 				echo "</module>" >> $@ ; \
 			fi ; \

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16591
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8b81a429bb037b997ee6640ff8a2b5e860962bb7
Gerrit-Change-Number: 16591
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211011/411b1b7c/attachment.html>