[Asterisk-code-review] message_send_ami: Make compatible with sipp 3.5.2 (testsuite[18])

Friendly Automation asteriskteam at digium.com
Fri Oct 8 09:48:22 CDT 2021


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/testsuite/+/16598 )

Change subject: message_send_ami: Make compatible with sipp 3.5.2
......................................................................

message_send_ami: Make compatible with sipp 3.5.2

sipp 3.5.2 seems to have issues with regexes that need to match
the beginning of the buffer so the test regex needed to be
updated.  Also updated the test-config.yaml to make it a bit
more robust detecting the end of the test.

ASTERISK-29677

Change-Id: I19d2d7bc62f0f3db1c1cbec5aabffe435d3f0eba
---
M tests/channels/pjsip/message/message_send_ami/sipp/message_recv.xml
M tests/channels/pjsip/message/message_send_ami/test-config.yaml
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/tests/channels/pjsip/message/message_send_ami/sipp/message_recv.xml b/tests/channels/pjsip/message/message_send_ami/sipp/message_recv.xml
index b1fa7a3..5289611 100644
--- a/tests/channels/pjsip/message/message_send_ami/sipp/message_recv.xml
+++ b/tests/channels/pjsip/message/message_send_ami/sipp/message_recv.xml
@@ -4,7 +4,7 @@
 <scenario name="MESSAGE receive from AMI">
 	<recv request="MESSAGE" crlf="true">
 		<action>
-			<ereg search_in="msg" regexp="^MESSAGE\s+sip:user1 at 127.0.0.1:5061\s+SIP/2[.]0"
+			<ereg search_in="msg" regexp="MESSAGE sip:user1 at 127.0.0.1:5061 SIP/2.0"
 				check_it="true" assign_to="junk1"/>
 			<ereg search_in="hdr" header="From:" regexp="sip:user0"
 				check_it="true" assign_to="junk2"/>
diff --git a/tests/channels/pjsip/message/message_send_ami/test-config.yaml b/tests/channels/pjsip/message/message_send_ami/test-config.yaml
index 61218ee..a5fcd0e 100644
--- a/tests/channels/pjsip/message/message_send_ami/test-config.yaml
+++ b/tests/channels/pjsip/message/message_send_ami/test-config.yaml
@@ -24,6 +24,7 @@
 test-object-config:
     reactor-timeout: 15
     connect-ami: True
+    stop-after-scenarios: False
     test-iterations:
         -
             scenarios:
@@ -51,3 +52,4 @@
                     MdataFrom: 'sip:user0'
                     MsgTo: 'sip:ralph at somewhere.com'
             count: 1
+        stop_test:

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16598
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 18
Gerrit-Change-Id: I19d2d7bc62f0f3db1c1cbec5aabffe435d3f0eba
Gerrit-Change-Number: 16598
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211008/29744624/attachment.html>


More information about the asterisk-code-review mailing list