[Asterisk-code-review] chan_sip: Add custom SIP tag capabilities (asterisk[master])

George Joseph asteriskteam at digium.com
Fri Oct 8 08:40:28 CDT 2021


Attention is currently required from: N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16569 )

Change subject: chan_sip: Add custom SIP tag capabilities
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: 
I haven't looked at the code yet but...
The proper terminology is "parameters" instead of "tags".
Parameters inside the "<>" are "URI" parameters.
Parameters outside the "<>" are "Header" parameters.
You should adjust appropriately.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16569
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1e99a220295c03275827050147622a6c1f5a4be9
Gerrit-Change-Number: 16569
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 08 Oct 2021 13:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211008/bdcdc836/attachment-0001.html>


More information about the asterisk-code-review mailing list