[Asterisk-code-review] test_voicemail_api.c: changing empty_msg_ids from 0 element array to ... (asterisk[master])

George Joseph asteriskteam at digium.com
Fri Oct 8 08:30:11 CDT 2021


Attention is currently required from: Michael Bradeen.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16571 )

Change subject: test_voicemail_api.c: changing empty_msg_ids from 0 element array to empty char* chan_skinny.c: changed calledParty size to AST_MAX_EXTENSION menuselect Makefile: added -Wno-deprecated-declarations
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
Also looks like your "master" branch is quite old so you'll want to rebase this change on the current state of master.

git checkout master
git pull
git switch -  ## to go back to your review branch
git rebase master
git commit -a --amend
## make commit message changes
git review



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16571
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If4fe42222c8444dc16828a42731ee53b4ce5cbbe
Gerrit-Change-Number: 16571
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Fri, 08 Oct 2021 13:30:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211008/bb68a4f9/attachment-0001.html>


More information about the asterisk-code-review mailing list