[Asterisk-code-review] asterisk.py: Fix TypeError when replacing instanceid (testsuite[16])

George Joseph asteriskteam at digium.com
Thu Oct 7 14:01:19 CDT 2021


Attention is currently required from: George Joseph.
Hello Joshua Colp, Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/testsuite/+/16572

to look at the new patch set (#2).

Change subject: asterisk.py: Fix TypeError when replacing instanceid
......................................................................

asterisk.py: Fix TypeError when replacing instanceid

id = 23
value = "test <<instanceid>> test"
value.replace("<<instanceid>>", id) fails with a TypeError because
replace doesn't automatically convert the numeric replacement
argument to a string.

Now doing value.replace("<<instanceid>>", str(id))

ASTERISK-29675

Change-Id: I16ec4dc84303ae3c3bdd1884959559675f6143c8
---
M lib/python/asterisk/asterisk.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/72/16572/2
-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I16ec4dc84303ae3c3bdd1884959559675f6143c8
Gerrit-Change-Number: 16572
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211007/349acefb/attachment.html>


More information about the asterisk-code-review mailing list