[Asterisk-code-review] progdocs: Fix grouping for latest Doxygen. (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Mon Nov 29 13:55:15 CST 2021


Attention is currently required from: Alexander Traud.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17334 )

Change subject: progdocs: Fix grouping for latest Doxygen.
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> The problem is not that easy. […]
I understand the review process as well as the concept of separation of concerns. In general I agree a patch should be a targeted fix, but depending on the circumstances I don't see the harm in minor breakages to that opinion.

In this case the reason I asked is because it seemed like it would be a small, partially related change to improve the documentation in a section of code you were already working in.

However, if for any reason you feel uncomfortable, unwilling, or unable to make to make a particular modification, or submit a patch, please and always feel free to explain why and not do so. Reasonable opinions are always considered. For example, your reasons given here would have been, and are perfectly valid in my opinion for not wanting to make the requested modification.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17334
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4687857b9d56e6f44fd440b73af156691660202e
Gerrit-Change-Number: 17334
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Mon, 29 Nov 2021 19:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Alexander Traud <pabstraud at compuserve.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211129/7594ccff/attachment.html>


More information about the asterisk-code-review mailing list