[Asterisk-code-review] progdocs: Fix grouping for latest Doxygen. (asterisk[master])
Alexander Traud
asteriskteam at digium.com
Wed Nov 24 13:21:38 CST 2021
Attention is currently required from: Kevin Harwell.
Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17334 )
Change subject: progdocs: Fix grouping for latest Doxygen.
......................................................................
Patch Set 1:
(1 comment)
File include/asterisk/rtp_engine.h:
https://gerrit.asterisk.org/c/asterisk/+/17334/comment/7eb35d83_3a36b673
PS1, Line 2901: /*! @} */
> I don't think most of the above belongs in the StasisTopicsAndMessages group. […]
Puh. This whole change is a pure syntactic one. You are asking for a semantic fix. Furthermore, I have no idea about stasis (and what it is). Therefore, I cannot double-check your recommendation. Consequently, I would give a +1 indirectly to your proposed change, a fix this change is not about. Normally, I would say, if that change is important enough for you, please, fix it afterwards. However, to get this change through, I followed your recommendation. Anyway, a fellow reviewer must note that this is not a +1 from me (there is a struct stasis_topic *ast_rtp_topic(void) not grouped now).
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17334
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4687857b9d56e6f44fd440b73af156691660202e
Gerrit-Change-Number: 17334
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 19:21:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211124/94626580/attachment.html>
More information about the asterisk-code-review
mailing list