[Asterisk-code-review] chan_sip: Fix crash when accessing RURI before initiating outgoing call (asterisk[master])

Sean Bright asteriskteam at digium.com
Wed Nov 24 09:01:24 CST 2021


Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17583 )

Change subject: chan_sip: Fix crash when accessing RURI before initiating outgoing call
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File channels/sip/dialplan_functions.c:

https://gerrit.asterisk.org/c/asterisk/+/17583/comment/9f5671a9_5a0d4873 
PS3, Line 169: 		if ((&p->initreq)->data) {
This syntax is a little weird. You're taking the address only to then dereference. Would the following work instead:

 if (p->initreq.data) {



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17583
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Icd3b02f07256bbe6615854af5717074087b95a83
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 15:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211124/deabf202/attachment.html>


More information about the asterisk-code-review mailing list