[Asterisk-code-review] func_json: Adds JSON_DECODE function (asterisk[master])

N A asteriskteam at digium.com
Thu Nov 18 12:09:36 CST 2021


Attention is currently required from: Joshua Colp, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16634 )

Change subject: func_json: Adds JSON_DECODE function
......................................................................


Patch Set 11:

(2 comments)

File funcs/func_json.c:

https://gerrit.asterisk.org/c/asterisk/+/16634/comment/46de800d_e4132347 
PS6, Line 109: 	result = ast_json_object_string_get(json, args.key);
> Ah yeah I agree. I would not be opposed to adding something like that to our json api. […]
I see how it would be done for string and int, but what about array or any of the other stuff? Not seeing how those would get converted to strings.


File funcs/func_json.c:

https://gerrit.asterisk.org/c/asterisk/+/16634/comment/a5945b78_7b671a78 
PS10, Line 111: 	switch(ast_json_typeof(jsonval)) {
> I _think_ this is NULL tolerant, but if you haven't tested might want to double check.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16634
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iea60c49a7358dfdc2db60803cdc9a742f808ba2c
Gerrit-Change-Number: 16634
Gerrit-PatchSet: 11
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 18 Nov 2021 18:09:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211118/702ff676/attachment.html>


More information about the asterisk-code-review mailing list