[Asterisk-code-review] func_json: Adds JSON_DECODE function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16634 )

Change subject: func_json: Adds JSON_DECODE function
......................................................................


Patch Set 7:

(1 comment)

File funcs/func_json.c:

https://gerrit.asterisk.org/c/asterisk/+/16634/comment/57245511_797c2b5b 
PS6, Line 109: 	result = ast_json_object_string_get(json, args.key);
> Yes related to ast_json_object_integer_get, and other types. […]
Hmm, I swear I tested it with int values and it seemed to work fine. If the key is a string and the value is retrieved as a string, I'm not sure I follow the issue. Every variable in Asterisk is a string anyways, so I'm not sure why it would be retrieved as an int just to convert back again. Other than "get a string field" and "get an integer field", they look the same.
I realized this case isn't tested by the unit tests. I just added a test and it seems to pass. I'll upload the revised version.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16634
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iea60c49a7358dfdc2db60803cdc9a742f808ba2c
Gerrit-Change-Number: 16634
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 18 Nov 2021 16:46:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211118/0266a386/attachment-0001.html>