[Asterisk-code-review] pbx: Add variable substitution API for extensions (asterisk[master])

N A asteriskteam at digium.com
Thu Nov 18 06:27:44 CST 2021


Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17470 )

Change subject: pbx: Add variable substitution API for extensions
......................................................................


Patch Set 7:

(2 comments)

File main/pbx.c:

https://gerrit.asterisk.org/c/asterisk/+/17470/comment/564cd2cb_5e6197ba 
PS4, Line 8620: 	ast_unlock_contexts();
> I _think_ you need to keep "contexts" locked throughout this function, or at least until you're done […]
Done


File main/pbx_variables.c:

https://gerrit.asterisk.org/c/asterisk/+/17470/comment/1dfd8293_23174015 
PS4, Line 769: 					ast_copy_string(workspace, context, VAR_BUF_SIZE);
> Should this be 'exten' instead of 'context'?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17470
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I23273bf27fa0efb64a606eebf9aa8e2f41a065e4
Gerrit-Change-Number: 17470
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 18 Nov 2021 12:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211118/55ea6118/attachment.html>


More information about the asterisk-code-review mailing list