[Asterisk-code-review] apps/app_dial.c: HANGUPCAUSE reason code for CANCEL is set to AST_CAU... (asterisk[18])

[Mark Petersen]

Attention is currently required from: Joshua Colp, George Joseph.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16344 )

Change subject: apps/app_dial.c: HANGUPCAUSE reason code for CANCEL is set to AST_CAUSE_NORMAL_CLEARING
......................................................................


Patch Set 11:

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16344/comment/c874c0d4_92e39597 
PS9, Line 7: res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_NORMAL_CLEARING
> I think this change is now across multiple things and this commit message doesn't describe them all. […]
Done


File res/res_pjsip_rfc3326.c:

https://gerrit.asterisk.org/c/asterisk/+/16344/comment/d3d851cd_4ff9dc02 
PS1, Line 108: 		if (ast_channel_hangupcause(session->channel) == AST_CAUSE_NOTDEFINED) {
> changed that if ast_channel_hangupcause = AST_CAUSE_NOTDEFINED to not send a Q. […]
Have removed this as ast_channel_hangupcause is now correct for CANCEL



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16344
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ib653aec2282f55b59d87484391cc07c8e6612b89
Gerrit-Change-Number: 16344
Gerrit-PatchSet: 11
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 18 Nov 2021 12:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211118/5b592a09/attachment.html>