[Asterisk-code-review] func_json: Adds JSON_DECODE function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16634 )

Change subject: func_json: Adds JSON_DECODE function
......................................................................


Patch Set 7:

(3 comments)

File funcs/func_json.c:

https://gerrit.asterisk.org/c/asterisk/+/16634/comment/a6ed1afb_d72304d4 
PS6, Line 43: 			Returns the contents of a JSON array at a specified key.
> This should be reworded as the function appears to not be returning the contents of a JSON array, bu […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16634/comment/fc28f3bf_3a163438 
PS6, Line 102: 	json = ast_json_load_string(ast_str_buffer(str), NULL);
> You can use 'ast_json_load_str', which basically does what you're doing here if you want.
Done


https://gerrit.asterisk.org/c/asterisk/+/16634/comment/0d79d9f1_0443a3d9 
PS6, Line 109: 	result = ast_json_object_string_get(json, args.key);
> Is it guaranteed that all key values will be of type "string", or should this care about other types […]
Hmm... is this related to also having ast_json_object_integer_get?
I would think string should encompass integer as well, just represented as a string, but not positive. I've also never seen JSON keys that weren't strings.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16634
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iea60c49a7358dfdc2db60803cdc9a742f808ba2c
Gerrit-Change-Number: 16634
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 18 Nov 2021 12:12:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211118/cbcbb759/attachment-0001.html>