[Asterisk-code-review] pbx: Add variable substitution API for extensions (asterisk[master])

N A asteriskteam at digium.com
Thu Nov 18 06:01:41 CST 2021


Attention is currently required from: N A.
Hello Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/17470

to look at the new patch set (#6).

Change subject: pbx: Add variable substitution API for extensions
......................................................................

pbx: Add variable substitution API for extensions

Currently, variable substitution involving dialplan
extensions is quite clunky since it entails obtaining
the current dialplan location, backing it up, storing
the desired variables for substitution on the channel,
performing substitution, then restoring the original
location.

In addition to being clunky, things could also go wrong
if an async goto were to occur and change the dialplan
location during a substitution.

Fundamentally, there's no reason it needs to be done this
way, so new API is added to allow for directly passing in
the dialplan location for the purposes of variable
substitution so we don't need to mess with the channel
information anymore. Existing API is not changed.

ASTERISK-29745 #close

Change-Id: I23273bf27fa0efb64a606eebf9aa8e2f41a065e4
---
M include/asterisk/pbx.h
M main/pbx.c
M main/pbx_variables.c
3 files changed, 57 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/70/17470/6
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17470
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I23273bf27fa0efb64a606eebf9aa8e2f41a065e4
Gerrit-Change-Number: 17470
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211118/0da72e50/attachment.html>


More information about the asterisk-code-review mailing list