[Asterisk-code-review] pbx: Add variable substitution API for extensions (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17470 )

Change subject: pbx: Add variable substitution API for extensions
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

File main/pbx.c:

https://gerrit.asterisk.org/c/asterisk/+/17470/comment/6742e0c4_af5253cc 
PS4, Line 8620: 	ast_unlock_contexts();
I _think_ you need to keep "contexts" locked throughout this function, or at least until you're done with the retrieved extension. Otherwise it's possible for the extension to be deleted while you're still referencing/accessing it.


File main/pbx_variables.c:

https://gerrit.asterisk.org/c/asterisk/+/17470/comment/0237da42_e79b7647 
PS4, Line 769: 					ast_copy_string(workspace, context, VAR_BUF_SIZE);
Should this be 'exten' instead of 'context'?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17470
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I23273bf27fa0efb64a606eebf9aa8e2f41a065e4
Gerrit-Change-Number: 17470
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 18 Nov 2021 00:15:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211117/97325f5d/attachment.html>