[Asterisk-code-review] app_voicemail: Refactor email generation functions (asterisk[master])

[Kevin Harwell]

Attention is currently required from: Sean Bright, N A, Stanislav Abramenkov, George Joseph, Benjamin Keith Ford.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16665 )

Change subject: app_voicemail: Refactor email generation functions
......................................................................


Patch Set 11: Code-Review-1

(5 comments)

Patchset:

PS11: 
CONFLICT (content): Merge conflict in apps/app_minivm.c

You'll have to rebase and resubmit. Also I noted a couple other minor things that you missed in the previous review.


File include/asterisk/utils.h:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/cf69964a_d1977f9b 
PS11, Line 347: int ast_base64_encode_file(FILE *inputfile, FILE *outputfile, char *endl);
Make endl const


https://gerrit.asterisk.org/c/asterisk/+/16665/comment/e474d9e2_3f07ba4c 
PS11, Line 355:  * \return zero on success, -1 on error.
Change this to '\retval 0' vs return zero


https://gerrit.asterisk.org/c/asterisk/+/16665/comment/bdbaf354_b5ee19a7 
PS11, Line 357: int ast_base64_encode_file_path(const char *filename, FILE *outputfile, char *endl);
make endl const


File include/asterisk/utils.h:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/2214054f_8b3be3d7 
PS10, Line 344:  * \return zero on success, -1 on error.
> Make this \retval instead of \return.
This still needs to be updated, s/return zero/retval 0.

Based on the other doxygen reviews it appears what you currently have will cause a warning when building the doxygen.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16665
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee
Gerrit-Change-Number: 16665
Gerrit-PatchSet: 11
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Wed, 17 Nov 2021 19:38:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211117/76a034bc/attachment.html>