[Asterisk-code-review] res_rtp_asterisk: Addressing possible rtp range issues (asterisk[16])

[Michael Bradeen]

Attention is currently required from: Sean Bright, Joshua Colp, Kevin Harwell.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16637 )

Change subject: res_rtp_asterisk: Addressing possible rtp range issues
......................................................................


Patch Set 3:

(7 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16637/comment/3558a576_fd5a3585 
PS2, Line 7: res_rtp: Addressing possible rtp range issues
> res_rtp_asterisk: Addressing possible rtp range issues.
Done


Patchset:

PS3: 
changes integrated


File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/16637/comment/c457a316_fd1eff95 
PS1, Line 3865: 	x = (x == rtpstart && x != (x & ~1)) ? rtpstart + 1 : x;
> It takes a little bit of staring to figure out what's going on here, so I think adding a comment exp […]
Done


File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/16637/comment/bf9ffe7f_6ed2db27 
PS2, Line 3869: condiction 
> s/condiction/condition/
Done


https://gerrit.asterisk.org/c/asterisk/+/16637/comment/a4902a74_14de8eba 
PS2, Line 3871: 	for (loopcounter = 0;loopcounter <= maxloops;loopcounter++) {
> Spaces after semis. Also using 'i' would be less verbose and more idiomatic.
Done


https://gerrit.asterisk.org/c/asterisk/+/16637/comment/435af922_2fad0af4 
PS2, Line 9715: 	if(rtpstart & 1) {
> Needs a space after if.
Done


https://gerrit.asterisk.org/c/asterisk/+/16637/comment/7f91045a_c90e56f5 
PS2, Line 9716: 		ast_log(LOG_WARNING, "Odd start value for RTP port in rtp.conf, rounding up\n");
> This should state the port so the user knows.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16637
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I90f07deef0716da4a30206e9f849458b2dbe346b
Gerrit-Change-Number: 16637
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 17 Nov 2021 15:40:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211117/954607b2/attachment.html>